chore(ci): trigger release workflow from pushes to main#533
Closed
dustinbyrne wants to merge 1 commit intomainfrom
Closed
chore(ci): trigger release workflow from pushes to main#533dustinbyrne wants to merge 1 commit intomainfrom
dustinbyrne wants to merge 1 commit intomainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 27-28
Comment:
**Unused `bump-type` output**
`bump-type` is declared as a job output and set unconditionally to `""` in every code path, but no downstream job (`check-release-label`, `release`, `notify-*`) ever reads `needs.resolve-release-context.outputs.bump-type`. Per the simplicity rule "has no superfluous parts," consider removing it — or add a comment explaining it is a placeholder for future bump-label support if that's the intent.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "chore(ci): trigger release workflow from..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+27
to
+28
| should-release: ${{ steps.resolve.outputs.should-release }} | ||
| bump-type: ${{ steps.resolve.outputs.bump-type }} |
Contributor
There was a problem hiding this comment.
bump-type output
bump-type is declared as a job output and set unconditionally to "" in every code path, but no downstream job (check-release-label, release, notify-*) ever reads needs.resolve-release-context.outputs.bump-type. Per the simplicity rule "has no superfluous parts," consider removing it — or add a comment explaining it is a placeholder for future bump-label support if that's the intent.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 27-28
Comment:
**Unused `bump-type` output**
`bump-type` is declared as a job output and set unconditionally to `""` in every code path, but no downstream job (`check-release-label`, `release`, `notify-*`) ever reads `needs.resolve-release-context.outputs.bump-type`. Per the simplicity rule "has no superfluous parts," consider removing it — or add a comment explaining it is a placeholder for future bump-label support if that's the intent.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
posthog-python Compliance ReportDate: 2026-04-23 22:07:09 UTC ✅ All Tests Passed!30/30 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 1/1 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The release workflow was triggered by
pull_request.closed, so protected release environments could be requested from arefs/pull/*/mergeref instead ofrefs/heads/mainafter a PR merged. That can cause environment protection to reject the release even though the PR landed onmain.This ports the CI release fix from PostHog/posthog-js#3461.
Changes
pushtomaininstead ofpull_request.closed.workflow_dispatchfor manual releases.resolve-release-contextjob that skips automated version-bump commits, finds the PR associated with the pushed commit, and only continues when the merged PR currently has thereleaselabel.💚 How did you test it?
.github/workflows/release.ymlas YAML.actionlinton.github/workflows/release.yml(ignoring the pre-existingactions/create-github-app-token@v3client-id/app-idwarning where that already exists in the workflow).📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file